✨ Move doc generation code away from cmd into lrcore, alongside tests#6030
Merged
preslavgerchev merged 1 commit intomainfrom Oct 10, 2025
Merged
✨ Move doc generation code away from cmd into lrcore, alongside tests#6030preslavgerchev merged 1 commit intomainfrom
preslavgerchev merged 1 commit intomainfrom
Conversation
Contributor
Test Results4 511 tests +1 4 507 ✅ +1 2m 13s ⏱️ -1s Results for commit 85a4984. ± Comparison against base commit ee64f7b. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
preslavgerchev
force-pushed
the
preslav/shuffle-lr-code
branch
4 times, most recently
from
0080b5b to
4c09562
Compare
preslavgerchev
force-pushed
the
preslav/shuffle-lr-code
branch
3 times, most recently
from
a0027d3 to
5e69bc7
Compare
…. the LR ast now has a GenerateDocs function. Signed-off-by: Preslav <preslav@mondoo.com>
preslavgerchev
force-pushed
the
preslav/shuffle-lr-code
branch
from
5e69bc7 to
85a4984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lrcorecmdintolrcoreGenerateDocsfn to the LR struct.The cmd package now has very little logic and most of this is in
lrcore, allowing us to easily test this